feat(remote_signer): Add job token signing endpoint for byoc job types#3869
Draft
feat(remote_signer): Add job token signing endpoint for byoc job types#3869
Conversation
…o orchestrator and update gRPC spec - Introduced ExternalCapabilities method in the orchestrator to retrieve registered external capabilities. - Updated OrchestratorInfo message in protobuf to include external capabilities information. - Enhanced gRPC client and server implementations to utilize new method and handle external capabilities. - Added new ExternalCapabilityInfo message to define external capabilities with attributes like name, description, capacity, and pricing. - Updated remote signer to support BYOC job type and handle capability-specific logic in payment processing. - Adjusted tests to accommodate new external capabilities functionality.
…ethods - Removed PriceInfo field from ExternalCapabilityInfo in both protobuf and Go files to streamline capability information. - Updated orchestratorInfoWithCaps function to reflect the removal of PriceInfo, ensuring compatibility with existing external capabilities logic. - Adjusted related comments and documentation to maintain clarity and accuracy.
- Added a new route for retrieving capabilities at "/byoc/capabilities". - Introduced GetCapabilities method to handle HTTP requests and return a JSON response with external capabilities information. - Updated Orchestrator interface to include ExternalCapabilities method for fetching registered capabilities. - Removed ExternalCapabilityInfo from protobuf and related files to streamline capability management. - Adjusted orchestratorInfoWithCaps function to reflect changes in external capabilities handling.
- Downgraded protoc-gen-go-grpc version from v1.6.0 to v1.2.0. - Updated gRPC support package version requirement from v1.64.0 to v1.32.0. - Replaced constant method names with direct string references for RPC calls in the OrchestratorClient and OrchestratorServer interfaces. - Adjusted comments for clarity and consistency in the generated code.
github-actions
bot
added
go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Checklist:
makeruns successfully./test.shpass