Skip to content

fix: init pod run perms #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix: init pod run perms #161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions controllers/resource_helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,8 @@ done`, CABundleTempPath, CABundleSourceDir, fileList)
},
},
SecurityContext: &corev1.SecurityContext{
AllowPrivilegeEscalation: &[]bool{false}[0],
RunAsNonRoot: &[]bool{false}[0],
AllowPrivilegeEscalation: ptr.To(false),
RunAsNonRoot: ptr.To(false),
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
},
Expand Down Expand Up @@ -446,8 +446,12 @@ func configurePersistentStorage(instance *llamav1alpha1.LlamaStackDistribution,
},
},
SecurityContext: &corev1.SecurityContext{
RunAsUser: ptr.To(int64(0)), // Run as root to be able to change ownership
RunAsGroup: ptr.To(int64(0)),
RunAsUser: ptr.To(int64(0)), // Run as root to be able to change ownership
RunAsGroup: ptr.To(int64(0)),
AllowPrivilegeEscalation: ptr.To(false),
Capabilities: &corev1.Capabilities{
Drop: []corev1.Capability{"ALL"},
},
},
}

Expand Down Expand Up @@ -601,6 +605,16 @@ func configurePodOverrides(instance *llamav1alpha1.LlamaStackDistribution, podSp
podSpec.ServiceAccountName = instance.Name + "-sa"
}

// Configure pod-level security context for OpenShift SCC compatibility
if podSpec.SecurityContext == nil {
podSpec.SecurityContext = &corev1.PodSecurityContext{}
}

// Set fsGroup to allow write access to mounted volumes
if podSpec.SecurityContext.FSGroup == nil {
podSpec.SecurityContext.FSGroup = ptr.To(int64(0))
}

// Apply other pod overrides if specified
if instance.Spec.Server.PodOverrides != nil {
// Add volumes if specified
Expand Down