chore: remove review-requested=0 condition to prevent auto-merge blocking

[derekhiggins]

Allows Mergify to auto-merge PRs even when there are pending review requests, as long as the minimum approval threshold is met and no changes are requested.

This prevents situations where PRs with sufficient approvals get blocked because some requested reviewers haven't responded yet.

[mergify]

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 📃 Configuration Change Requirements

Wonderful, this rule succeeded.

Mergify configuration change

• check-success = Configuration changed

[derekhiggins]

Marked as draft while discussions are ongoing

[nathan-weinberg]

I'm in favor of this, if we can do a 2-approval minimum.

[derekhiggins]

@nathan-weinberg an alternative (I think I prefer) would be to remove code-owners all together so users don't get auto added as reviewers. Then if anybody should review then they can be manually added.

[leseb]

@nathan-weinberg an alternative (I think I prefer) would be to remove code-owners all together so users don't get auto added as reviewers. Then if anybody should review then they can be manually added.

YES YES YES.

[nathan-weinberg]

@nathan-weinberg an alternative (I think I prefer) would be to remove code-owners all together so users don't get auto added as reviewers. Then if anybody should review then they can be manually added.

YES YES YES.

Let's please use GitHub Teams or some other mechanism then so if we want groups of people looking at things (Dev, QE, Docs, etc) we can add them more easily

[derekhiggins]

Let's please use GitHub Teams or some other mechanism then so if we want groups of people looking at things (Dev, QE, Docs, etc) we can add them more easily

hmm, I'm not sure if we can do this, they would need to be setup at the org level (I think), or is there somewhere they can be setup in the repo?

[nathan-weinberg]

Let's please use GitHub Teams or some other mechanism then so if we want groups of people looking at things (Dev, QE, Docs, etc) we can add them more easily

hmm, I'm not sure if we can do this, they would need to be setup at the org level (I think), or is there somewhere they can be setup in the repo?

Alas I think you are right - I'd be happy to do this if I can get the permissions, otherwise we may need to indeed cut down on the codeowners and do manual additions of individuals