chore: Updating Vector IO integration tests to use llama stack build #3836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
fyi, this might get nuked by #2974 where I already fixed this up |
franciscojavierarceo
force-pushed
the
update-vector-io-tests
branch
2 times, most recently
from
74debcb to
8d99350
Compare
Signed-off-by: Francisco Javier Arceo <[email protected]>
franciscojavierarceo
force-pushed
the
update-vector-io-tests
branch
from
0aaa0d7 to
da7b39a
Compare
franciscojavierarceo
requested review from
ashwinb,
bbrowning,
ehhuang,
hardikjshah,
leseb,
mattf,
raghotham,
reluctantfuturist,
slekkala1,
terrytangyuan and
yanxi0830
as code owners
cdoern
reviewed
Oct 17, 2025
| - name: Build Llama Stack | ||
| run: | | ||
| uv run --no-sync llama stack build --template ci-tests --image-type venv | ||
| uv run --no-sync llama stack build --distro starter --image-type venv --single-provider "vector_io=${{ matrix.vector-io-provider }}" |
There was a problem hiding this comment.
curious, should we stick with ci-tests distro similar to other integration tests? Or is there a benefit to starter here
| ) | ||
|
|
||
| self.parser.add_argument( | ||
| "--single-provider", |
There was a problem hiding this comment.
nice. I will migrate this to list-deps too
Signed-off-by: Francisco Javier Arceo <[email protected]>
|
@franciscojavierarceo Why do we need to add a -- pass the and that's it. NO OTHER CHANGES needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrate
vector-iointegration tests from--stack-configto use the starter distro andllama stack build, which is a much bigger reliability benefit.Requires filtering vector-io providers for integration tests.
Also fixed a type issue from post training that was exposed from doing this.
Splitting this out from #3818
Test Plan
Added unit tests and CI