Feat/timeseries - #151
Open
ruocco wants to merge 3 commits into
Open
Conversation
The palette had five series hues and a rule to fold anything past them into "Other", but no color to fold onto. Signed-off-by: Angelo Ruocco <ang@zurich.ibm.com>
The two primitives were separate pill groups differing only in arity, so StatPills becomes a preset and its hardcoded slate borders give way to the theme token. Signed-off-by: Angelo Ruocco <ang@zurich.ibm.com>
BRv0.2 reports embed per-timestamp pod metrics that had nowhere to surface, so a run's behaviour over time was invisible in the comparison view. The metric selector is the union of embedded keys across the selected runs, and metrics whose units agree can be overlaid on one axis; a panel's overflow past the hue budget folds onto one neutral. Signed-off-by: Angelo Ruocco <ang@zurich.ibm.com>
Contributor
|
Hi, thank you for the PR! Could you share some llm-d-benchmark results with time-series data as examples? |
Collaborator
|
Thanks for submitting the PR @ruocco. +1 to @diamondburned's request to add some benchmarks that highlight this new capability. Can you submit them through the results store: https://prism.llm-d.ai/?view=results-store? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for Benchmark Report's 0.2.1 time-series visualization
Why is this change needed?
Allows better understanding of certain workload
How was this tested?
Checklist
git commit -s) per DCOnpm test)npm run lint)Panel example