feat(telemetry): align kvcache OTel scope and span names with router standard - #2164
Open
Alex-ai-future wants to merge 1 commit into
Open
feat(telemetry): align kvcache OTel scope and span names with router standard#2164Alex-ai-future wants to merge 1 commit into
Alex-ai-future wants to merge 1 commit into
Conversation
Alex-ai-future
requested review from
a team,
liu-cong,
sagearc and
vMaroon
as code owners
July 24, 2026 06:27
Contributor
|
🚨 Unsigned commits detected! Please sign your commits. For instructions on how to set up GPG/SSH signing and verify your commits, please see GitHub Documentation. |
github-actions
Bot
added
the
size/L
Contributor
Author
|
cc @yankay — this aligns the router-internalized kvcache packages with the OTel scope/span naming from llm-d-kv-cache#654, using router-specific scope paths ( |
…standard Apply the same instrumentation scope and span naming conventions from llm-d-kv-cache#654 to the router-internalized kvcache packages, using router-specific scope paths. - Add TracerScope constants for kvcache and kvblock packages - Use tracing.Tracer() from pkg/common/observability/tracing - Shorten span names: drop llm_d.kv_cache.* prefix - Add Lookup span test coverage (hit, miss, error) Signed-off-by: Alex <jihui.huang@daocloud.io>
Alex-ai-future
force-pushed
the
review/kv-cache-pr-654
branch
from
July 24, 2026 06:37
8b4c099 to
d3324df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align OpenTelemetry naming in the router-internalized kvcache packages with the conventions established in llm-d-kv-cache#654. This allows operators to filter traces across kv-cache and router in a unified dashboard.
Changes
"llm-d-kv-cache/pkg/kvcache""llm-d-router/pkg/kvcache"llm_d.kv_cache.score_tokens,llm_d.kv_cache.scorer.compute,llm_d.kv_cache.index.add,llm_d.kv_cache.index.evict,llm_d.kv_cache.indexscore_tokens,compute_scores,index_add,index_evict,index_lookuptelemetry.Tracer()frompkg/telemetrytracing.Tracer()frompkg/common/observability/tracingllm_d.kv_cache.*Impact
service.nameremainsllm-d-router(no change).pkg/telemetryis left untouched, pending the fast follow cleanup requested by ahg-g in PR Internalize kvcache and kvevents libraries from llm-d-kv-cache #1886.Test plan
go test ./pkg/kvcache/...go test ./pkg/telemetry/...Release note