refactor(datalayer): key AttributeMap by DataKey instead of string - #2190
Draft
satyamg1620 wants to merge 1 commit into
Draft
refactor(datalayer): key AttributeMap by DataKey instead of string#2190satyamg1620 wants to merge 1 commit into
satyamg1620 wants to merge 1 commit into
Conversation
Signed-off-by: satyamg1620 <Satyam.Gupta.3@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Plugins declare the data they exchange as
DataKeyvalues, butAttributeMapaccess took a raw string. Nothing tied a plugin's reads and writes to itsProduces()/Consumes()declaration — a plugin could declare one key and useanother.
This types
AttributeMapbyDataKey:An undeclared raw-string key is now a compile error. scheduling.Endpoint restates these methods, so the change reaches every plugin call site.
Custom scalar metrics are named in configuration rather than in code, so attrmetrics.ScalarMetricDataKey derives their key from the configured name, keeping the extractor and its readers on one construction path.
Not covered: the key still isn't checked against the calling plugin's own declaration. That needs a per-plugin scoped accessor and is worth a separate issue.
Which issue(s) this PR fixes:
Fixes #1223