cicd/bug: query live labels in hold gate instead of (stale) event payload - #2200
Merged
Conversation
github-actions
Bot
added
size/S
elevran
changed the title
github-actions
Bot
added
kind/bug
github.event.pull_request.labels is frozen at trigger time, so a manual rerun of a failed hold-gate job kept failing after the hold label was removed. Fetch current labels via the GitHub API instead. Fixes llm-d#2199 Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
Signed-off-by: Etai Lev Ran <elevran@gmail.com>
elevran
force-pushed
the
worktree-fix-hold-gate-rerun
branch
from
July 29, 2026 12:11
f84c8ca to
f1ccc47
Compare
ahg-g
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The Hold gate workflow checked
github.event.pull_request.labels.*.name, which is frozen at the time the run was triggered. Re-running a failed hold-gate job (via the Actions UI) replays that stale payload instead of refetching current labels, so the check keeps failing even after thehold/do-not-merge/holdlabel is removed. Only a brand-new triggering event (e.g. a new commit) would produce a fresh payload and let it pass.Instead of using the labels from the (stale) payload, this PR queries current labels via
gh pr viewinside the step, so reruns reflect the PR's actual current state.Which issue(s) this PR fixes:
Fixes #2199
Release note (write
NONEif no user-facing change):