Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Add folders for IntegerAddOp #6696

Open
3 tasks
mikeurbach opened this issue Feb 14, 2024 · 3 comments
Open
3 tasks

[FIRRTL] Add folders for IntegerAddOp #6696

mikeurbach opened this issue Feb 14, 2024 · 3 comments
Labels
FIRRTL Involving the `firrtl` dialect good first issue Good for newcomers

Comments

@mikeurbach
Copy link
Contributor

This is a primitive Property operation, defined by FIRRTL spec section 25.1.1. General folds for signed arbitrary precision integer arithmetic can be applied, but none were defined in the initial PR. This could include things like:

  • integer_add(a, 0) -> a
  • integer_add(constantA, constantB) -> constantA + constantB
  • etc...
@mikeurbach mikeurbach added good first issue Good for newcomers FIRRTL Involving the `firrtl` dialect labels Feb 14, 2024
@sazimi13
Copy link

Hey I would like to take this issue up, after completing can hopefully take the other 2 folding issues as well.

@sazimi13
Copy link

sazimi13 commented Oct 6, 2024

Can you please provide the FIRRTL spec that you are referring to? @mikeurbach

@mikeurbach
Copy link
Contributor Author

Yep, the FIRRTL spec is located here: https://github.com/chipsalliance/firrtl-spec/blob/main/spec.md#integer-add-operation. That link points to the section for the integer add operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants