[CIR][CodeGen] Use signed type for result of ptrdiff operation. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugr
commented
Dec 15, 2023
bcardosolopes
requested changes
Dec 19, 2023
lanza
force-pushed
the
main
branch
2 times, most recently
from
05ffb2a
to
34fceae
Compare
yugr
force-pushed
the
ptrdiff-fix
branch
2 times, most recently
from
58eb780
to
a7816b1
Compare
yugr
changed the title
|
Test fails seem unrelated, looks like current trunk is failing on Mac and Windows. |
Yea, I fixed that yesterday, but a rebase is needed in order "to see it". Let me try to land this before you have to rebase. |
|
It worked! If you look at the commit list in github, you can see which commits landed green (there's a green check mark). |
Interesting. All our PRs started failing on Win/Mac after rebase, that's why I thought it's a trunk problem. |
|
It was, but you created your PR before I landed 8bd43c4 |
lanza
pushed a commit
that referenced
this pull request
Jan 29, 2024
Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
…#355) Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
…#355) Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
…#355) Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
…#355) Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…#355) Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…#355) Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix attached test case has been failing due to type mismatch (signed vs unsigned).