[CIR][CodeGen] support array def after decl with unknown bound #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your recent PRs, I'm currently on vacation but should resume reviewing patches by next Wed. Cheers. |
Arrays can be first declared without a known bound, and then defined with a known bound. clangir crashes on generating CIR for this case. This patch adds support.
sitio-couto
reviewed
Jan 4, 2024
There was a problem hiding this comment.
Hey @Lancern, thanks for the contribution!
It seems that this patch is solving a different assertion than the one triggered by the example provided in the PR description. This is possible because the new isValidRedeclarationType(Entry.getSymType(), Ty) statement evaluates to true, effectively changing the code path for the example code. In the original codegen, this evaluates to false.
This is the assertion causing the crash:
I would suggest trying to update these changes to fix this assertion instead.
| @@ -546,7 +574,7 @@ CIRGenModule::getOrCreateCIRGlobal(StringRef MangledName, mlir::Type Ty, | |||
| assert(0 && "not implemented"); | |||
|
|
|||
| // TODO(cir): check TargetAS matches Entry address space | |||
| if (Entry.getSymType() == Ty && | |||
| if (isValidRedeclarationType(Entry.getSymType(), Ty) && | |||
There was a problem hiding this comment.
I believe this diverges from the original codegen. The Entry.getSymType() == Ty statement should be evaluated as false.
Comment on lines
938
to
946
| if (!GV || GV.getSymType() != InitType) { | ||
| // TODO(cir): this should include an address space check as well. | ||
| assert(0 && "not implemented"); | ||
| setTypeOfGlobal(GV, InitType); | ||
| } |
There was a problem hiding this comment.
Oddly, the counterpart for this code section is not executed in the original codegen for the example in the PR description, despite the comment indicating otherwise.
Lancern
force-pushed
the
array-decl-unknown-bound
branch
from
0c65f1c
to
0766623
Compare
|
@sitio-couto Thanks for your helpful review! I have updated the code according to the review. |
bcardosolopes
requested changes
Jan 4, 2024
sitio-couto
reviewed
Jan 4, 2024
bcardosolopes
approved these changes
Jan 4, 2024
SchrodingerZhu
suggested changes
Jan 4, 2024
Lancern
commented
Jan 4, 2024
SchrodingerZhu
approved these changes
Jan 5, 2024
Lancern
force-pushed
the
array-decl-unknown-bound
branch
2 times, most recently
from
2bca2f4
to
5edd5ce
Compare
lanza
pushed a commit
that referenced
this pull request
Jan 29, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
Arrays can be first declared without a known bound, and then defined
with a known bound. For example:
```cpp
extern int data[];
int test() { return data[1]; }
int data[3] {1, 2, 3};
```
Currently `clangir` crashes on generating CIR for this case. This is due
to the type of the `data` definition being different from its
declaration. This patch adds support for such a case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays can be first declared without a known bound, and then defined with a known bound. For example:
Currently
clangircrashes on generating CIR for this case. This is due to the type of thedatadefinition being different from its declaration. This patch adds support for such a case.