-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CIR][ABI] Apply CC lowering pass by default #842
Merged
bcardosolopes
merged 12 commits into
llvm:main
from
sitio-couto:vinicius/run-cc-lowering-by-default
Sep 28, 2024
Merged
[CIR][ABI] Apply CC lowering pass by default #842
bcardosolopes
merged 12 commits into
llvm:main
from
sitio-couto:vinicius/run-cc-lowering-by-default
Sep 28, 2024
Commits on Sep 21, 2024
-
[CIR][ABI] Apply CC lowering pass by default
Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the `-fno-clangir-call-conv-lowering` flag if necessary. The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation. From an implementation perspective, several `llvm_unreachable` statements have been substituted with a new `assert_or_abort` macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does. A few notable changes: - Support multi-block function in CC lowering - Ignore pointer-related CC lowering - Ignore no-proto functions CC lowering - Handle missing type evaluation kinds - Fix CC lowering for function declarations - Unblock indirect function calls - Disable CC lowering pass on several tests
Configuration menu - View commit details
-
Copy full SHA for 03f5745 - Browse repository at this point
Copy the full SHA 03f5745View commit details -
Configuration menu - View commit details
-
Copy full SHA for a48ccc6 - Browse repository at this point
Copy the full SHA a48ccc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00b7b36 - Browse repository at this point
Copy the full SHA 00b7b36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 634e5ef - Browse repository at this point
Copy the full SHA 634e5efView commit details -
Configuration menu - View commit details
-
Copy full SHA for b65590c - Browse repository at this point
Copy the full SHA b65590cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5574bcb - Browse repository at this point
Copy the full SHA 5574bcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c346cf1 - Browse repository at this point
Copy the full SHA c346cf1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 289ef0f - Browse repository at this point
Copy the full SHA 289ef0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 21e78b1 - Browse repository at this point
Copy the full SHA 21e78b1View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7736e57 - Browse repository at this point
Copy the full SHA 7736e57View commit details -
Apply CC lowering only when --emit-cir-flat and by default when lower…
…ing through MLIR
Configuration menu - View commit details
-
Copy full SHA for ded4eb9 - Browse repository at this point
Copy the full SHA ded4eb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0768a4 - Browse repository at this point
Copy the full SHA b0768a4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.