[CIR][Bugfix] renames minor/major parameters of the OpenCLVersionAttr #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like certain names should not be used - I even could not build CIR on the Ubuntu with a relatively old glibc version.
In this case
minor
andmajor
are macroses and can not be used in this context.You can take a look at the comments in the mlir/test/lib/Dialect/Test/TestDialect.h reference as well