Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][Asm] Parse extra attributes after calling convention #847

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

keryell
Copy link
Contributor

@keryell keryell commented Sep 16, 2024

Align parsing of cir.call with its pretty-printing.

Align parsing of cir.call with its pretty-printing.
@keryell
Copy link
Contributor Author

keryell commented Sep 17, 2024

Curious this

Failed Tests (1):
  Clang :: CIR/CodeGen/global-new.cpp

It works for me but someone reported such an error to me.

@keryell
Copy link
Contributor Author

keryell commented Sep 17, 2024

I see, this is the intermittent failure already mentioned in #829

@bcardosolopes
Copy link
Member

Looks like there's a code format error though, can you look into that?

@keryell
Copy link
Contributor Author

keryell commented Sep 17, 2024

Looks like there's a code format error though, can you look into that?

This is what I thought first when I created the PR but it looks more like an infrastructure problem in the GitHub action:

Run pip install -r code-format-tools/llvm/utils/git/requirements_formatting.txt
Collecting black==23.12.1 (from -r code-format-tools/llvm/utils/git/requirements_formatting.txt (line 7))
  Downloading black-23.12.1-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (68 kB)
Collecting certifi==2024.2.2 (from -r code-format-tools/llvm/utils/git/requirements_formatting.txt (line 11))
  Downloading certifi-2024.2.2-py3-none-any.whl.metadata (2.2 kB)
Collecting cffi==1.16.0 (from -r code-format-tools/llvm/utils/git/requirements_formatting.txt (line 13))
  Downloading cffi-1.16.0-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (1.5 kB)
Collecting charset-normalizer==3.3.2 (from -r code-format-tools/llvm/utils/git/requirements_formatting.txt (line 17))
  Downloading charset_normalizer-3.3.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (33 kB)
Collecting click==8.1.7 (from -r code-format-tools/llvm/utils/git/requirements_formatting.txt (line 19))
  Downloading click-8.1.7-py3-none-any.whl.metadata (3.0 kB)
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='pypi.org', port=443): Read timed out. (read timeout=15)")': /simple/cryptography/
WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='pypi.org', port=443): Read timed out. (read timeout=15)")': /simple/cryptography/
WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='pypi.org', port=443): Read timed out. (read timeout=15)")': /simple/cryptography/
WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='pypi.org', port=443): Read timed out. (read timeout=15)")': /simple/cryptography/
WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'ReadTimeoutError("HTTPSConnectionPool(host='pypi.org', port=443): Read timed out. (read timeout=15)")': /simple/cryptography/
ERROR: Could not find a version that satisfies the requirement cryptography==42.0.5 (from versions: none)
ERROR: No matching distribution found for cryptography==42.0.5

and I do not have enough rights to rerun the check just to see whether it is a transient problem or not.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for double checking, must be a fluke (code looks formatted AFAICS)

@bcardosolopes bcardosolopes merged commit 45f360d into llvm:main Sep 17, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants