[CIR][CodeGen] Reflow global generation to match clang CodeGen #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
Created using spr 1.3.5
Created using spr 1.3.5
lanza
force-pushed
the
main
branch
2 times, most recently
from
67ce904
to
845c25a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shortcut global inits earlier in the life of ClangIR. We'll have to
tear back some "support" temporarily to thread it through correctly.
buildCXXGlobalVarDeclInitFuncwas shortcut to skip lots of logic andjust jump to the function that actually generates the globals. Remove
that logic for now and flesh out the function a bit with a bunch of
stubbed out code that needs to follow this commit.