[CIR] Split cir-simplify into two passes #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch splits the old cir-simplify pass into two new passes, namely cir-canonicalize and cir-simplify (the new cir-simplify). The cir-canonicalize pass runs transformations that do not affect CIR-to-source fidelity much, such as operation folding and redundant operation elimination. On the other hand, the new cir-simplify pass runs transformations that may significantly change the code and break high-level code analysis passes, such as more aggresive code optimizations. This patch also updates the CIR-to-CIR pipeline to fit these two new passes. The cir-canonicalize pass is moved to the very front of the pipeline, while the new cir-simplify pass is moved to the back of the pipeline (but still before lowering prepare of course). Additionally, the new cir-simplify now only runs when the user specifies a non-zero optimization level on the frontend.
bcardosolopes
approved these changes
Sep 19, 2024
| @@ -293,11 +169,7 @@ void CIRSimplifyPass::runOnOperation() { | |||
| // Collect operations to apply patterns. | |||
| SmallVector<Operation *, 16> ops; | |||
| getOperation()->walk([&](Operation *op) { | |||
| // CastOp here is to perform a manual `fold` in | |||
| // applyOpPatternsAndFold | |||
| if (isa<BrOp, BrCondOp, ScopeOp, SwitchOp, CastOp, TryOp, UnaryOp, | |||
There was a problem hiding this comment.
We can tackle this in followup PRs, but shouldn't UnaryOp be part of CIRSimplify? Some of its folding definitely affects source fidelity, perhaps we need to move some of that logic out of the ::fold into a rewriter in CIRSimplify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the old
cir-simplifypass into two new passes, namelycir-canonicalizeandcir-simplify(the newcir-simplify). Thecir-canonicalizepass runs transformations that do not affect CIR-to-source fidelity much, such as operation folding and redundant operation elimination. On the other hand, the newcir-simplifypass runs transformations that may significantly change the code and break high-level code analysis passes, such as more aggresive code optimizations.This PR also updates the CIR-to-CIR pipeline to fit these two new passes. The
cir-canonicalizepass is moved to the very front of the pipeline, while the newcir-simplifypass is moved to the back of the pipeline (but still before lowering prepare of course). Additionally, the newcir-simplifynow only runs when the user specifies a non-zero optimization level on the frontend.Also fixed some typos and resolved some
clang-tidycomplaints along the way.Resolves #827 .