[mlir][IR][NFC] PostDominanceInfo: Mark all functions as const
#115597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesSame as Depends on #115587. Full diff: https://github.com/llvm/llvm-project/pull/115597.diff 2 Files Affected:
diff --git a/mlir/include/mlir/IR/Dominance.h b/mlir/include/mlir/IR/Dominance.h
index a6b2475e12b1c6..63504cad211a4d 100644
--- a/mlir/include/mlir/IR/Dominance.h
+++ b/mlir/include/mlir/IR/Dominance.h
@@ -196,18 +196,18 @@ class PostDominanceInfo : public detail::DominanceInfoBase</*IsPostDom=*/true> {
/// Return true if operation A properly postdominates operation B.
bool properlyPostDominates(Operation *a, Operation *b,
- bool enclosingOpOk = true);
+ bool enclosingOpOk = true) const;
/// Return true if operation A postdominates operation B.
- bool postDominates(Operation *a, Operation *b) {
+ bool postDominates(Operation *a, Operation *b) const {
return a == b || properlyPostDominates(a, b);
}
/// Return true if the specified block A properly postdominates block B.
- bool properlyPostDominates(Block *a, Block *b);
+ bool properlyPostDominates(Block *a, Block *b) const;
/// Return true if the specified block A postdominates block B.
- bool postDominates(Block *a, Block *b) {
+ bool postDominates(Block *a, Block *b) const {
return a == b || properlyPostDominates(a, b);
}
};
diff --git a/mlir/lib/IR/Dominance.cpp b/mlir/lib/IR/Dominance.cpp
index 25bdc32dd6a2a7..1c54e09d29b9b5 100644
--- a/mlir/lib/IR/Dominance.cpp
+++ b/mlir/lib/IR/Dominance.cpp
@@ -352,13 +352,13 @@ bool DominanceInfo::properlyDominates(Value a, Operation *b) const {
//===----------------------------------------------------------------------===//
bool PostDominanceInfo::properlyPostDominates(Operation *a, Operation *b,
- bool enclosingOpOk) {
+ bool enclosingOpOk) const {
return super::properlyDominatesImpl(a->getBlock(), a->getIterator(),
b->getBlock(), b->getIterator(),
enclosingOpOk);
}
-bool PostDominanceInfo::properlyPostDominates(Block *a, Block *b) {
+bool PostDominanceInfo::properlyPostDominates(Block *a, Block *b) const {
return super::properlyDominatesImpl(a, a->end(), b, b->end(),
/*enclosingOk=*/true);
}
|
matthias-springer
force-pushed
the
users/matthias-springer/block_dom
branch
from
9979c63
to
247e4db
Compare
matthias-springer
force-pushed
the
users/matthias-springer/post_dom_constant
branch
from
caea72f
to
e890126
Compare
joker-eph
approved these changes
Nov 10, 2024
Same as `DominanceInfo`, all functions should be `const`.
matthias-springer
force-pushed
the
users/matthias-springer/post_dom_constant
branch
from
e890126
to
943bd95
Compare
matthias-springer
requested review from
JDevlieghere,
nikic and
a team
as code owners
matthias-springer
changed the base branch from
users/matthias-springer/block_dom
to
main
matthias-springer
deleted the
users/matthias-springer/post_dom_constant
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/3473 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as
DominanceInfo, all functions should beconst.