Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang] [unittests] Link to libMLIR in optimizer tests #123476

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Jan 18, 2025

Handle the one unittest executable that I've missed in #120966.

Handle the one unittest executable that I've missed in llvm#120966.
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Jan 18, 2025
@llvmbot
Copy link
Member

llvmbot commented Jan 18, 2025

@llvm/pr-subscribers-flang-fir-hlfir

Author: Michał Górny (mgorny)

Changes

Handle the one unittest executable that I've missed in #120966.


Full diff: https://github.com/llvm/llvm-project/pull/123476.diff

1 Files Affected:

  • (modified) flang/unittests/Optimizer/CMakeLists.txt (+5-2)
diff --git a/flang/unittests/Optimizer/CMakeLists.txt b/flang/unittests/Optimizer/CMakeLists.txt
index c58fb226a175c9..f535677c19fd2f 100644
--- a/flang/unittests/Optimizer/CMakeLists.txt
+++ b/flang/unittests/Optimizer/CMakeLists.txt
@@ -9,8 +9,6 @@ set(LIBS
   FIRDialectSupport
   FIRSupport
   HLFIRDialect
-  ${dialect_libs}
-  ${extension_libs}
   LLVMTargetParser
 )
 
@@ -47,3 +45,8 @@ DEPENDS
 target_link_libraries(FlangOptimizerTests
   PRIVATE
   ${LIBS})
+mlir_target_link_libraries(FlangOptimizerTests
+  PRIVATE
+  ${dialect_libs}
+  ${extension_libs}
+  )

@mgorny mgorny merged commit 04034f0 into llvm:main Jan 19, 2025
11 checks passed
@mgorny mgorny deleted the flang-mlir-dylib-pt2 branch January 19, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:fir-hlfir flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants