Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang][lit] mkdir before mkstemp in is_filesystem_case_insensitive() #131036

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aeubanks
Copy link
Contributor

In the CMake build test_exec_root already exists here, but not in the gn build, which causes this to fail.

In the CMake build test_exec_root already exists here, but not in the gn build, which causes this to fail.
@aeubanks aeubanks requested a review from nico March 12, 2025 21:44
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Mar 12, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 12, 2025

@llvm/pr-subscribers-clang

Author: Arthur Eubanks (aeubanks)

Changes

In the CMake build test_exec_root already exists here, but not in the gn build, which causes this to fail.


Full diff: https://github.com/llvm/llvm-project/pull/131036.diff

1 Files Affected:

  • (modified) clang/test/lit.cfg.py (+1)
diff --git a/clang/test/lit.cfg.py b/clang/test/lit.cfg.py
index 9820ddd1f14af..074167fa6cad3 100644
--- a/clang/test/lit.cfg.py
+++ b/clang/test/lit.cfg.py
@@ -253,6 +253,7 @@ def have_host_clang_repl_cuda():
 
 
 def is_filesystem_case_insensitive():
+    os.mkdir(config.test_exec_root)
     handle, path = tempfile.mkstemp(prefix="case-test", dir=config.test_exec_root)
     isInsensitive = os.path.exists(
         os.path.join(os.path.dirname(path), os.path.basename(path).upper())

@aeubanks aeubanks requested a review from zmodem March 12, 2025 23:42
Copy link
Collaborator

@zmodem zmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants