Skip to content

Conversation

zibi2
Copy link
Contributor

@zibi2 zibi2 commented Aug 28, 2025

Remove __classic_upper_table() and __classic_lower_table() from cxx03. The previous patch removed those function but declaration was left in cxx03 header. This is more cleaning up patch.

@zibi2 zibi2 requested a review from philnik777 August 28, 2025 20:30
@zibi2 zibi2 requested a review from a team as a code owner August 28, 2025 20:30
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 28, 2025
@llvmbot
Copy link
Member

llvmbot commented Aug 28, 2025

@llvm/pr-subscribers-libcxx

Author: Zibi Sarbinowski (zibi2)

Changes

Remove __classic_upper_table() and __classic_lower_table() from cxx03. The previous patch removed those function but declaration was left in cxx03 header. This is more cleaning up patch.


Full diff: https://github.com/llvm/llvm-project/pull/155916.diff

1 Files Affected:

  • (modified) libcxx/include/__cxx03/__locale (-12)
diff --git a/libcxx/include/__cxx03/__locale b/libcxx/include/__cxx03/__locale
index d5faa89b99fc0..86160bcdcbd59 100644
--- a/libcxx/include/__cxx03/__locale
+++ b/libcxx/include/__cxx03/__locale
@@ -582,18 +582,6 @@ public:
 #endif
   _LIBCPP_HIDE_FROM_ABI const mask* table() const _NOEXCEPT { return __tab_; }
   static const mask* classic_table() _NOEXCEPT;
-#if defined(__GLIBC__) || defined(__EMSCRIPTEN__)
-  static const int* __classic_upper_table() _NOEXCEPT;
-  static const int* __classic_lower_table() _NOEXCEPT;
-#endif
-#if defined(__NetBSD__)
-  static const short* __classic_upper_table() _NOEXCEPT;
-  static const short* __classic_lower_table() _NOEXCEPT;
-#endif
-#if defined(__MVS__)
-  static const unsigned short* __classic_upper_table() _NOEXCEPT;
-  static const unsigned short* __classic_lower_table() _NOEXCEPT;
-#endif
 
 protected:
   ~ctype() override;

@philnik777 philnik777 merged commit 95a9a26 into llvm:main Aug 29, 2025
70 of 76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants