Skip to content

Conversation

ilovepi
Copy link
Contributor

@ilovepi ilovepi commented Aug 29, 2025

After #155957 pointed it out, we're actually using the frontend PGO in
the Fuchsia cmake cache files.

After #155957 pointed it out, we're actually using the frontend PGO in
the Fuchsia cmake cache files.
@ilovepi ilovepi requested a review from petrhosek August 29, 2025 17:00
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Aug 29, 2025
Copy link
Contributor Author

ilovepi commented Aug 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented Aug 29, 2025

@llvm/pr-subscribers-clang

Author: Paul Kirth (ilovepi)

Changes

After #155957 pointed it out, we're actually using the frontend PGO in
the Fuchsia cmake cache files.


Full diff: https://github.com/llvm/llvm-project/pull/156060.diff

1 Files Affected:

  • (modified) clang/cmake/caches/Fuchsia.cmake (+1-1)
diff --git a/clang/cmake/caches/Fuchsia.cmake b/clang/cmake/caches/Fuchsia.cmake
index a3f86f673b493..46ae7c603f67a 100644
--- a/clang/cmake/caches/Fuchsia.cmake
+++ b/clang/cmake/caches/Fuchsia.cmake
@@ -179,7 +179,7 @@ set(BOOTSTRAP_LLVM_ENABLE_LLD ON CACHE BOOL "")
 set(BOOTSTRAP_LLVM_ENABLE_LTO ON CACHE BOOL "")
 
 if(FUCHSIA_ENABLE_PGO)
-  set(BOOTSTRAP_LLVM_BUILD_INSTRUMENTED ON CACHE BOOL "")
+  set(BOOTSTRAP_LLVM_BUILD_INSTRUMENTED IR CACHE BOOL "")
 
   set(_FUCHSIA_BOOTSTRAP_TARGETS
     generate-profdata

@ilovepi ilovepi enabled auto-merge (squash) August 29, 2025 17:31
@ilovepi ilovepi merged commit a22d4de into main Aug 29, 2025
11 checks passed
@ilovepi ilovepi deleted the users/ilovepi/fuchsia-pgo branch August 29, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants