Skip to content

Conversation

Camsyn
Copy link
Contributor

@Camsyn Camsyn commented Oct 11, 2025

This pull request makes a minor fix to the llvm/utils/lit/lit/llvm/config.py file.

The change corrects a missing comma in the list of environment variables, ensuring that "UBSAN_SYMBOLIZER_PATH" and "ASAN_OPTIONS" are treated as separate entries instead of a single concatenated string.

  • Fixed a missing comma between "UBSAN_SYMBOLIZER_PATH" and "ASAN_OPTIONS" in the environment variable list in llvm/utils/lit/lit/llvm/config.py, preventing potential configuration issues.

@Camsyn Camsyn self-assigned this Oct 11, 2025
@Camsyn Camsyn changed the title [lit] Fix the missing commas in LIT config [lit] Fix the missing comma in LIT config Oct 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 11, 2025

@llvm/pr-subscribers-testing-tools

Author: Kunqiu Chen (Camsyn)

Changes

This pull request makes a minor fix to the llvm/utils/lit/lit/llvm/config.py file.

The change corrects a missing comma in the list of environment variables, ensuring that "UBSAN_SYMBOLIZER_PATH" and "ASAN_OPTIONS" are treated as separate entries instead of a single concatenated string.

  • Fixed a missing comma between "UBSAN_SYMBOLIZER_PATH" and "ASAN_OPTIONS" in the environment variable list in llvm/utils/lit/lit/llvm/config.py, preventing potential configuration issues.

Full diff: https://github.com/llvm/llvm-project/pull/162998.diff

1 Files Affected:

  • (modified) llvm/utils/lit/lit/llvm/config.py (+2-1)
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index c134cda90e2ee..cc94389e85f74 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -80,7 +80,8 @@ def __init__(self, lit_config, config):
                 "HWASAN_SYMBOLIZER_PATH",
                 "MSAN_SYMBOLIZER_PATH",
                 "TSAN_SYMBOLIZER_PATH",
-                "UBSAN_SYMBOLIZER_PATH" "ASAN_OPTIONS",
+                "UBSAN_SYMBOLIZER_PATH",
+                "ASAN_OPTIONS",
                 "HWASAN_OPTIONS",
                 "MSAN_OPTIONS",
                 "RTSAN_OPTIONS",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants