Skip to content

[CIR][CodeGen] Use MapVector instead of StringMap for replacements #181969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andykaylor merged 1 commit into from
Feb 18, 2026
Merged

[CIR][CodeGen] Use MapVector instead of StringMap for replacements #181969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clang/lib/CIR/CodeGen/CIRGenModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,7 +1163,7 @@ void CIRGenModule::replacePointerTypeArgs(cir::FuncOp oldF, cir::FuncOp newF) {

void CIRGenModule::applyReplacements() {
for (auto &i : replacements) {
StringRef mangledName = i.first();
StringRef mangledName = i.first;
mlir::Operation *replacement = i.second;
mlir::Operation *entry = getGlobalValue(mangledName);
if (!entry)
Expand Down
3 changes: 1 addition & 2 deletions clang/lib/CIR/CodeGen/CIRGenModule.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,8 +730,7 @@ class CIRGenModule : public CIRGenTypeCache {
llvm::StringMap<clang::GlobalDecl, llvm::BumpPtrAllocator> manglings;

// FIXME: should we use llvm::TrackingVH<mlir::Operation> here?
typedef llvm::StringMap<mlir::Operation *> ReplacementsTy;
ReplacementsTy replacements;
llvm::MapVector<StringRef, mlir::Operation *> replacements;
/// Call replaceAllUsesWith on all pairs in replacements.
void applyReplacements();

Expand Down