Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated CUDA_TOOLKIT_ROOT_DIR with CUDAToolkit_ROOT #213

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Replace deprecated CUDA_TOOLKIT_ROOT_DIR with CUDAToolkit_ROOT #213

merged 1 commit into from
Jun 21, 2024

Conversation

Meinersbur
Copy link
Member

LLVM does not use CUDA_TOOLKIT_ROOT_DIR anymore after llvm/llvm-project@3de162f. Instead use CUDAToolkit_ROOT to let CMake search for CUDA.

@Meinersbur Meinersbur marked this pull request as ready for review June 21, 2024 18:23
jhuber6
jhuber6 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not sure this was ever correct in the first place since AFAIK it was just an empty string until the linked patch.

@Meinersbur
Copy link
Member Author

It did work before the liboffload refactor (buildbot was green at some point), but I don't know how CUDA_TOOLKIT_ROOT_DIR was forwarded into the runtimes-bin directory.

@Meinersbur Meinersbur merged commit 3abee03 into llvm:main Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhuber6 jhuber6 jhuber6 approved these changes

@jplehr jplehr Awaiting requested review from jplehr

@gkistanova gkistanova Awaiting requested review from gkistanova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meinersbur @jhuber6