Skip to content

Conversation

spall
Copy link
Collaborator

@spall spall commented Aug 12, 2025

add test for half and float versions of atan2
Closes #167

@damyanp damyanp requested review from kmpeng and inbelic August 18, 2025 19:44
Copy link
Collaborator

@llvm-beanz llvm-beanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few small comments on run lines

Copy link
Contributor

@kmpeng kmpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than one suggestion

@spall spall merged commit 870a0a2 into llvm:main Aug 22, 2025
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for atan2
4 participants