Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Torch]Decompose AtenScaledDotProductAttentionOp #3461

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

william0021224
Copy link
Contributor

@william0021224
Copy link
Contributor Author

@stellaraccident Could you please help to review this PR? Thanks!

@stellaraccident stellaraccident self-requested a review June 14, 2024 04:54
Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can accept this patch as a default pattern. Most production backends benefit from the op not being decomposed, and only if a backend needs it should it be opted in.

This needs to be in some kind of optional pass that the ref backend activates as part of its pipeline.

I'll need to defer to others for an opinion on the right way to organize it though. @rsuderman, @ramiro050

@william0021224
Copy link
Contributor Author

I don't think we can accept this patch as a default pattern. Most production backends benefit from the op not being decomposed, and only if a backend needs it should it be opted in.

This needs to be in some kind of optional pass that the ref backend activates as part of its pipeline.

I'll need to defer to others for an opinion on the right way to organize it though. @rsuderman, @ramiro050

No Problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants