[TorchToLinalg] Merge indices and pooling computation into one linalg generic op #3701
+250
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
93
to
99
| // CHECK: %[[MAX_PRED:.*]] = arith.cmpf ugt, %[[CURRENT_VALUE]], %[[ACC_OUT]] : f32 | ||
| // CHECK: %[[MAXF:.*]] = scf.if %[[MAX_PRED]] -> (f32) { | ||
| // CHECK: scf.yield %[[CURRENT_VALUE]] : f32 | ||
| // CHECK: } else { | ||
| // CHECK: scf.yield %[[ACC_OUT]] : f32 | ||
| // CHECK: } | ||
| // CHECK-NEXT: linalg.yield %[[MAXF]] : f32 |
There was a problem hiding this comment.
@lingzhiz1998 I haven't gone through the code in this PR, but this IR getting generated instead of the earlier one, is not good for the downstream pipeline, and I don't see a point in doing that.
There was a problem hiding this comment.
This PR aims to change the IR of max_pool _with_indices op to eliminate extract op. Generating different IRs for max_pool op is not necessary. The reason of why I did this is making the lowering logic of these ops as identical as possible. If you worry about this, I can keep the IR of max_pool op as same as previous.
lingzhiz1998
force-pushed
the
lingzhi/reimplement_maxpoolwithindices
branch
from
1bd975c
to
ae1fa20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3652, we should use one linalg generic op to represent maxpool with indices op.