Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOSA] Extend Torch to TOSA reduction ops legalization #3710

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

justin-ngo-arm
Copy link
Contributor

  • Add Torch to TOSA legalization for the following reduction ops:
    • aten.min.dim
    • aten.min
    • aten.max
    • aten.prod
    • aten.prod.dim_int
    • aten.all.dim
  • Add dtype casting support for reduce sum and prod ops
  • Extend aten.max.dim legalization to a template to support aten.min.dim legalization
  • Update end-to-end tests sets in xfail_sets.py

Signed-off-by: Justin Ngo [email protected]
Change-Id: I854dd6c0c55e570c1fb7242f20c85cf64d6e7fe0

- Add Torch to TOSA legalization for the following reduction ops:
  + aten.min.dim
  + aten.min
  + aten.max
  + aten.prod
  + aten.prod.dim_int
  + aten.all.dim
- Add dtype casting support for reduce sum and prod ops
- Extend aten.max.dim legalization to a template to support
aten.min.dim legalization
- Update end-to-end tests sets in xfail_sets.py
- Update basic.mlir with new legalized ops

Signed-off-by: Justin Ngo <[email protected]>
Change-Id: I854dd6c0c55e570c1fb7242f20c85cf64d6e7fe0
@justin-ngo-arm
Copy link
Contributor Author

Update basic.mlir with new legalized ops

@sjarus sjarus self-requested a review September 16, 2024 19:39
Copy link
Collaborator

@sjarus sjarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merging.

@sjarus sjarus merged commit 14ef05a into llvm:main Sep 16, 2024
3 checks passed
@justin-ngo-arm justin-ngo-arm deleted the reduction-ops branch November 4, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants