fix: 2 improvements across 2 files#2966
Open
tomaioo wants to merge 3 commits into
Open
Conversation
- Quality: Typo in function name - Quality: Bug in ensure_local function Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
- Quality: Typo in function name - Quality: Bug in ensure_local function Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
dipu-bd
reviewed
May 13, 2026
|
|
||
|
|
||
| def select_descendends(job_id: str, inclusive: bool = False): | ||
| def select_descendants(job_id: str, inclusive: bool = False): |
Collaborator
There was a problem hiding this comment.
please ensure this name change is reflected in everywhere this function is used
dipu-bd
requested changes
May 13, 2026
…ected in everywhere th Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: 2 improvements across 2 files
Problem
Severity:
Low| File:lncrawl/services/jobs/utils.py:L41Function 'select_descendends' in lncrawl/services/jobs/utils.py has a typo - should be 'select_descendants'
Solution
Rename function to 'select_descendants' to fix the typo
Changes
lncrawl/services/jobs/utils.py(modified)lncrawl/server/security.py(modified)