Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 149 149
======================================
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
550bb11 to
8614951
Compare
|
Somehow running test in the GitHub action breaks the test, couldn't replicate it. I'll modify to run all inside the docker-compose so it's replicable anywhere. Drafting for now. Running Eclair image in amd architecture panics from scpk issue. Running Eclair latests won't be stable. |
Just ping us here when it's ready for a review :) |
b52d420 to
d08fecb
Compare
|
@dunxen sorry that I've been swarming you with reviews requests 😅! This one is ready |
No stress! Keep them coming and thanks for working on these!. I'll take a look at this on Tuesday, the 29th. Out on a bush trip for the long weekend currently with choppy signal. |
|
Sorry for the delay. Still taking a closer look here. |
|
I'll have some time to take a look this weekend. :) EDIT: From a high level look, it's looking great, it'll be great to have these tests <3. But in the first commit it says "we generate an offer on Eclair without using blinding paths." I think it's important we have a test where Eclair does generate an offer with a blinded path. |
This commit adds a simple paying offer itest with eclair node. Uses docker compose to manage bitcoind and eclair node while continuing using lnd submodule and ldk nodes "in code". First we open a network LND <-> LDK Node <-> Eclair, we generate an offer on Eclair using blinding paths and finally LNDK pays the offer through the network.
6dfff17 to
eb19633
Compare
|
@orbitalturtle thanks for taking the time to review this! So I just force pushed and rewrote the commit message, we now are using blinded paths on the integration test 🙌🏼 |
This PR is part of #157
Bit of context
We would like to test paying offers from different implementations. We have different approaches to do here, adding submodules, building from source or use docker-compose like ldk node https://github.com/lightningdevkit/ldk-node/blob/main/docker-compose-cln.yml
What has been done
Add new simple test that spin up a network LND <-> LDK <-> Eclair. LND and LDK nodes are running in host machine while Eclair is inside docker-compose file specific for these tests.
After checking network is ready for doing payments, we generate an offer from Eclair and pay it from LNDK through the network.
These tests are behind a
cfg(eclair_test)so won't be running through other itests.Some considerations
Eclair does not have an official Image, I built images and uploaded to my own docker hub repository for ease of testing.
Added some docs to run the itest when developing and also macOS consideration because there isn't an images for arm either.