Mark Task::resume_all as unsafe
#86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thank you and sorry for the delay in getting back to you |
|
@schteve No worries, thanks for merging and maintaining this crate! |
|
Yeah we need a new version, it's been a while. I don't have rights to push a new version to crates.io, but I think @niondir can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this while working on #85. Suspending/resuming the scheduler is used for many snychonization tasks within FreeRTOS (e.g. queues), so wrongly calling
Task::resume_allwithout a matching previous call toTask::suspend_allwill wreak all sorts of havoc.Note that I did not mark
Task::suspend_allasunsafe- it should be safe to call this as often as one wants, the worst thing that happens is that the scheduler just stops doing anything, but no risk for memory safety.