Skip to content

Mark Task::resume_all as unsafe #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michael-p
Copy link
Contributor

Noticed this while working on #85. Suspending/resuming the scheduler is used for many snychonization tasks within FreeRTOS (e.g. queues), so wrongly calling Task::resume_all without a matching previous call to Task::suspend_all will wreak all sorts of havoc.
Note that I did not mark Task::suspend_all as unsafe - it should be safe to call this as often as one wants, the worst thing that happens is that the scheduler just stops doing anything, but no risk for memory safety.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant