Make the M3 example work with Rust stable toolchain #91
Conversation
JalonWong
force-pushed
the
m3
branch
2 times, most recently
from
b952c1e to
2ac8548
Compare
| env: | ||
| RUSTFLAGS: -D warnings # Warnings disabled only in CI | ||
| # env: | ||
| # RUSTFLAGS: -D warnings # Warnings disabled only in CI |
There was a problem hiding this comment.
What is the reason to re-enable warnings?
There was a problem hiding this comment.
Because there is no warning now, I think enabling it is better.
| key: ${{ runner.os }}-${{ runner.arch }} | ||
| - name: Install Rust | ||
| uses: dtolnay/rust-toolchain@nightly | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
I see this PR also has changes included in the other PR. I'll add my comments from the other PR here in case it makes sense to just merge this one.
It looks like this is changing the overall build to be stable, not the examples. I'm not sure if it makes sense to switch the whole project over to stable at this time. If the goal is to build only some examples with the stable toolchain, maybe it makes sense to make a copy of the examples section that runs only the ones that work on stable?
| // delay_n(555); | ||
| } | ||
| unsafe fn HardFault(_ef: &ExceptionFrame) -> ! { | ||
| // Blink 3 times long when exception occures |
There was a problem hiding this comment.
Is the comment still correct? I don't see anything that would blink now.
There was a problem hiding this comment.
I deleted the comment, the same as M4. And the function set_led() is not a very good example. I don't think we should encourage implementation like that.
The STM32L1 crate is too old, so I use F1 instead. I have debugged it, and it works well.
Depends on #90
resolve #66