Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 build: support to ignore \n with XXX_MODEL_LIST env #4660

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

coulsontl
Copy link
Contributor

@coulsontl coulsontl commented Nov 10, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

在docker compose文件里自定义模型时,如果模型比较多写在一行里不方便阅读,为了方便阅读只能换行写类似这样
image
但是这样写会出现模型为空字符串的情况
image
所以兼容一下名称名称里只包含空字符串和换行的情况

📝 补充信息 | Additional Information

Copy link

vercel bot commented Nov 10, 2024

@coulsontl is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 10, 2024
@lobehubbot
Copy link
Member

👍 @coulsontl

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (a4431f2) to head (143876d).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4660   +/-   ##
=======================================
  Coverage   92.55%   92.56%           
=======================================
  Files         517      517           
  Lines       36826    36831    +5     
  Branches     2295     2296    +1     
=======================================
+ Hits        34086    34091    +5     
  Misses       2740     2740           
Flag Coverage Δ
app 92.56% <100.00%> (+<0.01%) ⬆️
server 97.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充单测

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 10, 2024
@coulsontl
Copy link
Contributor Author

补充单测

@arvinxx 佬,已补充单测用例,并测试通过

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Supplementary single test

@arvinxx, I have added a single test case and passed the test

@arvinxx arvinxx changed the title chore: 解析自定义模型列表时兼容模型名称包含空字符串的情况 👷 build: support to parse \n with XXX_MODEL_LIST env Nov 12, 2024
Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Thanks for your contribution!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 12, 2024
@arvinxx arvinxx changed the title 👷 build: support to parse \n with XXX_MODEL_LIST env 👷 build: support to ignore \n with XXX_MODEL_LIST env Nov 12, 2024
@arvinxx arvinxx merged commit 6af7b52 into lobehub:main Nov 12, 2024
5 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @coulsontl ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.31.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coulsontl coulsontl deleted the parse_model branch November 12, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants