Fix ECR repository URL replacement for LocalStack 3.4 compatibility #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thuran
approved these changes
May 7, 2025
JezreelMoraes
approved these changes
May 7, 2025
igor-marchi
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #20, LocalStack version 3.4 introduced the
ECR_ENDPOINT_STRATEGYvariable, which changed how ECR endpoints are generated. This update affected the current domain replacement logic, resulting in invalid image repository names when using LocalStack’s ECR.For example:
Correct image name:
000000000000.dkr.ecr.us-east-1.amazonaws.com/sample5e8ff9bf/samplefunction757ff6efrepoEndpoint returned by LocalStack:
000000000000.dkr.ecr.us-east-1.localhost.localstack.cloud:4566/sample5e8ff9bf/samplefunction757ff6efrepoIncorrect result after the current replace:
000000000000.dkr.ecr.us-east-1.000000000000.dkr.ecr.us-east-1.localhost.localstack.cloud:4566/sample5e8ff9bf/samplefunction757ff6efrepoExpected result after replace:
000000000000.dkr.ecr.us-east-1.localhost.localstack.cloud:4566/sample5e8ff9bf/samplefunction757ff6efrepoThis incorrect replacement causes a "repository not found" error when uploading the image to the local ECR.
This PR updates the domain replacement logic to ensure compatibility with the changes introduced in LocalStack 3.4.