Skip to content

Allow range arguments to come as string. #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow range arguments to come as string. #108

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35074c9
Allow range arguments to come as string to fix redis.call from Lua.
amotzg Jun 23, 2016
03a48e5
Unit tess for client translation functions for range and limit.
amotzg Dec 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mockredis/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1444,6 +1444,8 @@ def _translate_range(self, len_, start, end):
"""
Translate range to valid bounds.
"""
start = int(start)
Copy link
Contributor

@srikalyan srikalyan Nov 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test to cover this case?

Copy link
Contributor Author

@amotzg amotzg Dec 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tester for client.py translation functions.
See comment about general test failure below.

end = int(end)
if start < 0:
start += len_
start = max(0, min(start, len_))
Expand Down