-
Notifications
You must be signed in to change notification settings - Fork 0
feat: update to consensus-specs v1.7.0-alpha.3 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Changes from 7 commits
893763c
f251ae3
ee5aad0
8c9b2cc
8056186
b14c3d2
0b8503a
95bf993
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -509,7 +509,7 @@ const forkChoiceTest = | |
| // integrated | ||
| shouldSkip: (_testcase, name, _index) => | ||
| name.includes("invalid_incorrect_proof") || | ||
| // TODO GLOAS: Proposer boost specs have been changed retroactively in v1.7.0-alpha.1, | ||
| // TODO GLOAS: Proposer boost specs have been changed retroactively in v1.7.0-alpha.3, | ||
|
||
| // and these tests are failing until we update our implementation. | ||
| name.includes("voting_source_beyond_two_epoch") || | ||
| name.includes("justified_update_always_if_better") || | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,10 +24,16 @@ const ignoredRemoteConfigFields: (keyof ChainConfig)[] = [ | |
| // Networking params that may be in presets instead of chainConfig | ||
| "ATTESTATION_SUBNET_COUNT" as keyof ChainConfig, | ||
| "ATTESTATION_SUBNET_EXTRA_BITS" as keyof ChainConfig, | ||
| "ATTESTATION_SUBNET_PREFIX_BITS" as keyof ChainConfig, | ||
| // Future spec params not yet in Lodestar | ||
| "EPOCHS_PER_SHUFFLING_PHASE" as keyof ChainConfig, | ||
| "PROPOSER_SELECTION_GAP" as keyof ChainConfig, | ||
| // EIP-7928 and EIP-8025 forks - not yet implemented in Lodestar | ||
| "EIP7928_FORK_EPOCH" as keyof ChainConfig, | ||
| "EIP7928_FORK_VERSION" as keyof ChainConfig, | ||
| "EIP8025_FORK_EPOCH" as keyof ChainConfig, | ||
| "EIP8025_FORK_VERSION" as keyof ChainConfig, | ||
| // Heze fork config | ||
| "HEZE_FORK_VERSION" as keyof ChainConfig, | ||
|
||
| // Network-specific fork epochs and versions - these vary per network deployment | ||
| // and are not meant to be synced from the spec defaults | ||
| "ALTAIR_FORK_EPOCH", | ||
|
|
@@ -37,6 +43,7 @@ const ignoredRemoteConfigFields: (keyof ChainConfig)[] = [ | |
| "ELECTRA_FORK_EPOCH", | ||
| "FULU_FORK_EPOCH", | ||
| "GLOAS_FORK_EPOCH", | ||
| "HEZE_FORK_EPOCH", | ||
| // Terminal values are network-specific | ||
| "TERMINAL_TOTAL_DIFFICULTY", | ||
| "TERMINAL_BLOCK_HASH", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to add the spec reference, please align with existing gossip checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the spec URL. Kept the inline
[IGNORE]comment to match the pattern of other gossip checks.