Skip to content

feat: add GPU pricing to Cost Control docs #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johannesfrey
Copy link
Contributor

@johannesfrey johannesfrey commented Mar 24, 2025

Content Description

Update: Setting this to draft until https://github.com/loft-sh/loft-enterprise/pull/4019 has been finalized.

Adds the GPU section to Cost Control docs.

Should be merged after all relevant vCluster platform PRs have been merged.

Preview Link

Internal Reference

Closes ENG-6247

@@ -71,6 +71,10 @@ config:
averageRAMPricePerNode:
price: 31
timePeriod: Monthly
# Average GPU cost
averageGPUPricePerNode:
price: 31
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what we should put as default here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizardruss can you help us what should be the default value here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @johannesfrey. This PR has been open for a while. When should this info go out? Is this linked to the 4.3 release?

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for vcluster-docs-site ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b3f7e45
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs-site/deploys/67e131465a6d2d000846da15
😎 Deploy Preview https://deploy-preview-554--vcluster-docs-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johannesfrey johannesfrey force-pushed the cost-control-gpu-docs branch from 8fc330f to b3f7e45 Compare March 24, 2025 10:17
@joaniekube joaniekube added the hold for release Waiting on eng or design dependencies to merge label Mar 25, 2025
@joaniekube
Copy link
Contributor

@johannesfrey added a Hold for release label for this. Has all relevant Eng work been release now?

@joaniekube joaniekube marked this pull request as ready for review March 28, 2025 19:32
@joaniekube joaniekube requested a review from a team as a code owner March 28, 2025 19:32
@johannesfrey johannesfrey marked this pull request as draft March 31, 2025 09:15
@johannesfrey
Copy link
Contributor Author

@johannesfrey added a Hold for release label for this. Has all relevant Eng work been release now?

Sorry, missed your comment @joaniekube. Not yet, I set it to draft until the eng part has been finalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold for release Waiting on eng or design dependencies to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants