-
Notifications
You must be signed in to change notification settings - Fork 535
feat: Add support for ingress network policies at vcluster creation time #3262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cbalan
wants to merge
9
commits into
loft-sh:main
Choose a base branch
from
cbalan:eng-9473-add-support-for-ingress-network-policies-configuration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: Add support for ingress network policies at vcluster creation time #3262
cbalan
wants to merge
9
commits into
loft-sh:main
from
cbalan:eng-9473-add-support-for-ingress-network-policies-configuration
+461
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6c4074e to
0a5bbb9
Compare
0a33ad8 to
4cc489e
Compare
9b27fd9 to
0e12908
Compare
0e12908 to
acc9bae
Compare
FabianKramm
requested changes
Nov 4, 2025
Member
FabianKramm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the "old" way?
FabianKramm
requested changes
Nov 4, 2025
This was referenced Nov 4, 2025
FabianKramm
requested changes
Nov 5, 2025
3b73ba4 to
2c33d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #ENG-9473
Please provide a short message that should be published in the vcluster release notes
Ingress network policies rules can be set at vcluster creation time, in addition to egress network policies.