Test/pre-seed test_qml_only app for integration-test boot - #343
Merged
Conversation
…suite time budget
…IT gates, xfail runner) and rea
…nc launcherApps refresh
…R gate scans real output
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add the stable automation handles enumerated in spec §4.1, following
the existing sidebar.app.<name> / confirmationDialog.<mode>.<button>
convention: welcomePage.installNow, appManager.{searchField,
category.<name>,emptyView}, appContextMenu root,
addApplicationDialog.{primaryButton,closeButton,errorText,
resolutionBanner}, settings.searchField,
pluginInterface.{call.<method>,result,back}, repositories.{urlField,
addButton,refreshButton,errorBanner,errorDismiss,row.<url>,
removeConfirm.{confirm,cancel}}, and sidebar.buildLabel.
workspace.dock.<name> is deliberately not applied: the dock root's
objectName is pinned to the bare module name by
workspace_area_test.cpp and needs a coordinated rename (recorded as
a finding).
Add fixture A (test_qml_only v0.1.1, ui_qml) and a seedPlugin(userDir, fixture) helper to tests/fixtures/lgx.mjs, and seed it into <user-dir>/plugins/ in nix/integration-test.nix before the app launches (MCP-TEST-PLAN v2 §0.A/§4.7). package_manager's installed lists are live directory scans for <name>/manifest.json, so the seeded fixture shows up in launcherApps at boot without any install IPC, giving sidebar/dock tests a real launcher app. A1 takes its "Welcome back" branch.
Collaborator
Jenkins Builds
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a pre-seeded QML-only launcher fixture to integration-test startup.
Changes:
- Defines the reusable
test_qml_onlyfixture and seeding helper. - Seeds the fixture into the isolated integration-test user directory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
tests/fixtures/lgx.mjs |
Defines and installs fixture A. |
nix/integration-test.nix |
Seeds fixture A before app launch. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
romanzac
marked this pull request as ready for review
August 25, 2026 05:26
Khushboo-dev-cpp
approved these changes
Aug 26, 2026
📊 basecamp doc-test reportThis commit of basecamp, built as both the dev app and the portable bundle and driven through its Modules view to inspect the installed UI plugins and loaded core modules — rendered alongside the commands/actions actually run and their output (updated each run, commit Pages can take a minute to update after the run finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add fixture A (test_qml_only v0.1.1, ui_qml) and a seedPlugin(userDir, fixture) helper to tests/fixtures/lgx.mjs, and seed it into /plugins/ in nix/integration-test.nix before the app launches.
Test plan
nix build .#appsucceedsnix build .#smoke-test -Lpassesnix build .#integration-test -Lpasses (if UI-visible)nix build .#doctests -Lif touched)Checklist
fix/,feat/,chore/,docs/,test/, orci/CLAUDE.md/README.md/docs/updated if behaviour or build steps changed.DS_Storefiles removed