Test/MCP UI sidebar build label matches backend.isPortableBuild - #364
Draft
romanzac wants to merge 2 commits into
Draft
Test/MCP UI sidebar build label matches backend.isPortableBuild#364romanzac wants to merge 2 commits into
romanzac wants to merge 2 commits into
Conversation
The footer previously showed the build type only when buildVersion was empty, but nix builds bake "0.0.0-dev" when VERSION is absent, so the build-type arm was dead there. Now the footer always appends "Portable" or "Dev" per backend.isPortableBuild, prefixing the version plus a separator when non-empty (e.g. "0.0.0-dev · Dev").
Spec MCP-TEST-PLAN §2.A A6 (amended 2026-08-28): read
backend.buildVersion and backend.isPortableBuild through the inspector,
then assert on the sidebar.buildLabel element's own text — it contains
the matching build-type token ("Portable"/"Dev") and never the other,
starts with buildVersion when non-empty, and is the bare token when
buildVersion is empty. Expectations are derived from the eval reads,
not hardcoded, and the assertion is scoped to the footer element so
DashboardView's "Dev build" text cannot satisfy it. Read-only against
the sidebar; placed after A5 and leaves workspace state untouched.
Contributor
Author
|
Portable and Dev build sidebar text proposal |
📊 basecamp doc-test reportThis commit of basecamp, built as both the dev app and the portable bundle and driven through its Modules view to inspect the installed UI plugins and loaded core modules — rendered alongside the commands/actions actually run and their output (updated each run, commit Pages can take a minute to update after the run finishes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
the sidebar footer shows the build type, with the version when presentMCP test.Test plan
nix build .#appsucceedsnix build .#smoke-test -Lpassesnix build .#integration-test -Lpasses (if UI-visible)nix build .#doctests -Lif touched)Checklist
fix/,feat/,chore/,docs/,test/, orci/CLAUDE.md/README.md/docs/updated if behaviour or build steps changed.DS_Storefiles removed