Update bindings-api.md - #127
Closed
Cofson wants to merge 13 commits into
Closed
Conversation
- ContentFilter - ContentTopic - FilterSubscription
Cofson
marked this pull request as ready for review
April 16, 2025 13:09
jimstir
reviewed
May 5, 2025
Comment on lines
826
to
825
| "/ipfs/id/1.0.0", | ||
| "/vac/waku/relay/2.0.0", | ||
| "/waku/relay/2.0.0", | ||
| "/ipfs/ping/1.0.0" |
Contributor
There was a problem hiding this comment.
This change is not correct, the /vac/waku/relay/2.0.0 is still used. See here
| - 1 - The operation failed for any reason. | ||
| `onErrCb` will be executed with the reason the function execution failed. | ||
| `onErrCb` will be executed with the reason the function execution failed | ||
| - 2 - The function is missing the `onOkCb` or `onErrCb` callback |
jimstir
reviewed
Jul 4, 2025
jimstir
left a comment
jimstir
left a comment
Contributor
There was a problem hiding this comment.
I see you updated the comment about the period for the one line I mentioned. You make the same changes for multiple lines. Check all your changes for period removal as they may not be necessary.
This spec is in draft, but the format does not follow the RFC template. Update this to include things like abstract, etc...
Comment on lines
+74
to
+77
| type JsonMessage* = ref object # https://rfc.vac.dev/spec/36/#jsonmessage-type | ||
| payload*: Base64String | ||
| contentTopic*: string | ||
| version*: uint |
Contributor
There was a problem hiding this comment.
The original is correct, you can look at the reference here. Check your other changes to json format does support (*) after variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved bindings-api.md in the waku/standards/core/36 folder