Refactor/remove eth nat - #176
Draft
aimendj wants to merge 2 commits into
Draft
Conversation
…ion with native multiaddress-based reachability settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the old nim-eth/NAT setup and replaces the legacy --nat options with libp2p's native --advertised-address support. Nodes can now advertise one or more IPv4/IPv6 addresses directly through libp2p Identify, with the configured URIs converted to the appropriate multiaddresses. It also cleans up the old NAT-related code and tests, updates stream timeout handling, and adds coverage for explicit address advertisement.