Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate unhealthy connection tolerance from malicious tolerance #944

Closed
youngjoon-lee opened this issue Dec 16, 2024 · 0 comments · Fixed by #1130
Closed

Separate unhealthy connection tolerance from malicious tolerance #944

youngjoon-lee opened this issue Dec 16, 2024 · 0 comments · Fixed by #1130
Assignees
Labels
Milestone

Comments

@youngjoon-lee
Copy link
Contributor

youngjoon-lee commented Dec 16, 2024

Summary

As discussing in the simulation result, we've update the specification to have two tolerance parameters $\lfloor\delta_{EEF}\rfloor$ and $\lceil \delta_{EEF} \rceil$ instead of just $\delta_{EEF}$. It's for applying different tolerances to malicious peer detection and unhealthy peer detection. The same applies to $\delta_{DEF}$ as well.

Reason

We've found that we may need to set $\delta_{EEF}=1.00$ to avoid marking healthy connections as malicious, as investigating the simulation result. But then, no peer would be detected as unhealthy in the end, if $EEF=1$, because $EEF - (EEF \times \delta_{EEF})=0$. Of course, if a peer emits no message at all, it will be detected as unhealthy. However, we want to make the unhealthy tolerance more useful. The conclusion is separating the unhealthy tolerance $\lfloor\delta_{EEF}\rfloor$ from the malicious tolerance $\lceil \delta_{EEF} \rceil$.

@youngjoon-lee youngjoon-lee self-assigned this Dec 16, 2024
@youngjoon-lee youngjoon-lee removed their assignment Dec 16, 2024
@youngjoon-lee youngjoon-lee added this to the Iteration 9 milestone Dec 19, 2024
@youngjoon-lee youngjoon-lee self-assigned this Feb 3, 2025
@youngjoon-lee youngjoon-lee changed the title Improve connetion monitoring tolerance parameters Separate unhealthy connection tolerance from malicious tolerance Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment