Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blend): separate unhealthy conn tolerance from malicious tolerance #1130

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Mar 12, 2025

1. What does this PR implement?

Closes #944.

Instead of having a single parameter effective_message_tolerance, now we have two separate parameters: effective_message_malicious_tolerance and effective_message_unhealthy_tolerance. Each tolerance is intended for use in detecting malicious connections and unhealthy connections, respectively, as defined in the spec. Please see the issue for more details.

2. Does the code have enough context to be clearly understood?

Yes

3. Who are the specification authors and who is accountable for this PR?

@youngjoon-lee

4. Is the specification accurate and complete?

Yes

5. Does the implementation introduce changes in the specification?

No

Checklist

Warning

Do not merge the PR if any of the following is missing:

  • 1. Description added.
  • 2. Context and links to Specification document(s) added.
  • 3. Main contact(s) (developers and specification authors) added
  • 4. Implementation and Specification are 100% in sync including changes. This is critical.
  • 5. Link PR to a specific milestone.

@youngjoon-lee youngjoon-lee added this to the Iteration 10 milestone Mar 12, 2025
@youngjoon-lee youngjoon-lee self-assigned this Mar 12, 2025
@youngjoon-lee youngjoon-lee linked an issue Mar 12, 2025 that may be closed by this pull request
@youngjoon-lee youngjoon-lee merged commit 1dce142 into master Mar 12, 2025
10 checks passed
@youngjoon-lee youngjoon-lee deleted the blend-unhealthy-param branch March 12, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate unhealthy connection tolerance from malicious tolerance
2 participants