Track logstash versions in .ci #1221
Conversation
Previously logstash versions were tracked in the logstash repo and curled during CI steps. This commit moves the source of truth to the `.ci` repo where the consumer of that information lives. This also changes the format from json to yaml to allow commenting in the file.
Temporarily include logstash-versions until logstash-plugins/.ci#77 is merged.
.ci/logstash-versions.yml
Outdated
| @@ -0,0 +1,16 @@ | |||
| # For all active streams track the latest 2 releases | |||
There was a problem hiding this comment.
As I understand we will remove this file once we land logstash-plugins/.ci#77, right?
| @@ -34,26 +34,22 @@ fi | |||
| # The ELASTIC_STACK_VERSION may be an alias, save the original before translating it | |||
There was a problem hiding this comment.
(flaky memory) Isn't this docker-setup.sh same with .ci one? 🤔
There was a problem hiding this comment.
Its slightly different. The pattern is that we download only the files in the upstream .ci repository that do not exist in the child plugin repo. So in this case, given we have a slightly different docker-setup.sh we use the one in this repo, not the upstream.
There was a problem hiding this comment.
Not a blocker for this task but when I took a look at the difference between es-output .ci/docker-setup.sh and central .ci/docker-setup.sh, the only difference (assuming we land this PR) I found is if [ "$INTEGRATION" == "true" ]; then.. (below) at the end.
if [ "$INTEGRATION" == "true" ]; then
pull_docker_snapshot "elasticsearch" $ELASTIC_STACK_VERSION_ALIAS
fi
I was curious if we move this logic to the central .ci, that would allow us removing this repo .ci/docker-setup.sh as well. Just want DRY if possible. We can follow up later with cleaning processes if it makes to you too.
This reverts commit 2aadeda.
|
logstash-plugins/.ci#79 should fix CI |
| @@ -34,26 +34,22 @@ fi | |||
| # The ELASTIC_STACK_VERSION may be an alias, save the original before translating it | |||
There was a problem hiding this comment.
Not a blocker for this task but when I took a look at the difference between es-output .ci/docker-setup.sh and central .ci/docker-setup.sh, the only difference (assuming we land this PR) I found is if [ "$INTEGRATION" == "true" ]; then.. (below) at the end.
if [ "$INTEGRATION" == "true" ]; then
pull_docker_snapshot "elasticsearch" $ELASTIC_STACK_VERSION_ALIAS
fi
I was curious if we move this logic to the central .ci, that would allow us removing this repo .ci/docker-setup.sh as well. Just want DRY if possible. We can follow up later with cleaning processes if it makes to you too.
|
Thanks @mashhurs for the suggestion. I filed https://github.com/elastic/ingest-dev/issues/5960 to track that. |
Previously logstash versions were tracked in the logstash repo and curled during
CI steps. This commit moves the source of truth to the
.cirepo where theconsumer of that information lives. This also changes the format from json to
yaml to allow commenting in the file.