Skip to content

Conversation

@kirre-bylund
Copy link
Contributor

No description provided.

@kirre-bylund kirre-bylund changed the base branch from main to dev November 12, 2024 14:28
@kirre-bylund kirre-bylund marked this pull request as ready for review November 13, 2024 21:37
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from 5b18a8e to 392c7db Compare November 14, 2024 08:57
@kirre-bylund
Copy link
Contributor Author

Request times have degraded slightly but within acceptable limits in my opinion:
The important numbers
Lowest 10% hovers around the same mark of 8ms±3ms (Before change was 8ms±2ms)
Average request time hovers around the same mark of 58ms±5ms (Before change was 56ms±3ms)

The degraded numbers
The highest 1% of the request has seen the largest degradation.
Before change it was 200ms±50ms, after the change it is now 300ms±50ms

Additionally, the longest running request from the test suite (which is really not a measurement of anything since it's so very circumstantial) increased from ~370ms being the highest I saw before the change to 1075ms being the highest I've seen after the change.

Conclusion
I think this is acceptable. Since the average and p10 degradation is negligible it must be the outliers that are causing the degradation. And my theory is that is almost entirely caused by me increasing max retries to 5 and applying an incremental backoff algorithm.

@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from 4e4b20c to 4288baa Compare November 14, 2024 10:56
@kirre-bylund
Copy link
Contributor Author

Remove AverageRequestTimeTest before merging

@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch 5 times, most recently from 1321e6a to c26ef58 Compare November 21, 2024 09:54
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from 62b490f to 7634e5e Compare November 21, 2024 15:12
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from a17330a to 59fd156 Compare December 5, 2024 10:46
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from 5fb6c3c to bbf60c4 Compare January 8, 2025 15:38
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from bbf60c4 to 2f11846 Compare January 9, 2025 09:25
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from ede8147 to ec6a1fd Compare January 9, 2025 14:15
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from ec6a1fd to 3790a34 Compare January 9, 2025 14:17
@kirre-bylund kirre-bylund force-pushed the feature/http-execution-queue branch from 88d7e83 to 88da18d Compare January 10, 2025 09:19
@kirre-bylund kirre-bylund merged commit 424fc8f into dev Jan 14, 2025
68 checks passed
@kirre-bylund kirre-bylund deleted the feature/http-execution-queue branch January 14, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants