Skip to content

Conversation

@kirre-bylund
Copy link
Contributor

@kirre-bylund kirre-bylund commented Nov 19, 2024

This contains two ugly workarounds mentioned below, but has now been tested and works.
Workarounds:

  • Backend needs enum values lowercased, so the request body for metadata operations converts the operations list to a new internal type that has the enums as strings and forces them to be lowercase. This is memory and cycle waste but is unfortunately how it needs to be at the moment.
  • When operations are performed to self, then the source field and source id field need to be either dropped or set to something valid. So I opted for setting it to the current player ULID.
    • This is no longer true. I changed it to setting source and source_id to null which worked fine. That is a simpler solution.

@kirre-bylund kirre-bylund merged commit 0ddacd1 into dev Nov 20, 2024
68 checks passed
@kirre-bylund kirre-bylund deleted the feature/player-metadata branch November 20, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants