Shore up exception and error handling in HTTP related methods #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves exception and error handling in HTTP-related methods by adding try-catch blocks and validation checks to prevent failures and improve debugging.
Key Changes:
- Added validation to skip query parameters with null or empty keys
- Wrapped HTTP request listener invocations in try-catch blocks to prevent one failing listener from affecting others
- Added exception handling to path parameter formatting methods with fallback to unformatted endpoints
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| Runtime/Game/Utilities/LootLockerHttpUtilities.cs | Added null/empty check for query parameter keys in addition to values |
| Runtime/Client/LootLockerHttpRequestData.cs | Wrapped listener invocations in try-catch to isolate listener exceptions |
| Runtime/Client/LootLockerHTTPClient.cs | Reordered operations to call listeners after adding request ID to completed set |
| Runtime/Client/EndPointClass.cs | Added try-catch blocks around string.Format calls with error logging and fallback behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
JohannesLoot
approved these changes
Oct 24, 2025
Contributor
JohannesLoot
left a comment
JohannesLoot
left a comment
There was a problem hiding this comment.
Tested and verified working, great stuff 👍
Merge it!
kirre-bylund
force-pushed
the
fix/safer-http-client
branch
from
f127266 to
21e4fda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.