Ensure map used for common map seeds is the same #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, upstream Map Rando only tries a specific map for one or 10 generations, depending on settings.
Using the same map seed only guarantees that you'll be iterating over the same set of maps, instead of always getting one specific map. This meant that AP players using the
common_mapoption could end up with a different map, depending on how many attempts their individual generations took.This adds a specific case for generations where
map_seed_apis set by settingmax_attempts_per_mapequal tomax_attempts, to ensure the map will not change, and therefore a same value ofmap_seed_mapwill guarantee the same map.