Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete typeguard checks #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Jul 1, 2024

Follow-up to #263

@dairiki
Copy link
Collaborator

dairiki commented Jul 2, 2024

@lovasoa @epenet I am currently traveling and dealing with family medical issues.
I can probably find some time to look at this in the next couple of days, but nothing is certain.

I think this looks fine. The one thing that pops out on initial glance is that we might want to adjust our pins

install_requires=[
"marshmallow>=3.18.0,",
"typing-inspect~=0.9.0",
"typeguard~=4.0.0",
# Need `dataclass_transform(field_specifiers)`
"typing-extensions>=4.2.0; python_version<'3.11'",
],

I think we might want to adjust these to typeguard ~= 4.0 (to address #272) .
And maybe typing-inspect >= 0.9.0 (semver does not apply to 0.* versions).

@epenet
Copy link
Contributor Author

epenet commented Jul 2, 2024

I created a separate PR to fix #272
See #273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants